Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nucliadb_texts2 #1704

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Add nucliadb_texts2 #1704

merged 2 commits into from
Jan 8, 2024

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Jan 8, 2024

Description

This is just adding the new crate, not yet being used in the index node

How was this PR tested?

Describe how you tested this PR.

Copy link

This pull request has been linked to Shortcut Story #8217: Searches with security.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a7bb24) 82.09% compared to head (fed8e21) 82.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1704      +/-   ##
==========================================
- Coverage   82.09%   82.07%   -0.03%     
==========================================
  Files         333      333              
  Lines       19400    19400              
==========================================
- Hits        15927    15923       -4     
- Misses       3473     3477       +4     
Flag Coverage Δ
ingest 69.25% <ø> (ø)
node-sidecar 95.62% <ø> (ø)
nucliadb 70.38% <ø> (-0.05%) ⬇️
reader 76.90% <ø> (ø)
search 79.24% <ø> (ø)
standalone 88.27% <ø> (ø)
train 63.33% <ø> (ø)
utils 81.24% <ø> (ø)
writer 85.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran requested a review from a team January 8, 2024 09:35
@lferran lferran merged commit 2779ff0 into main Jan 8, 2024
105 checks passed
@lferran lferran deleted the ferran/sc-8217/security-groups-texts2 branch January 8, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants