Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add summarize to sdk #1731

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Add summarize to sdk #1731

merged 3 commits into from
Jan 16, 2024

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Jan 16, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@lferran lferran requested a review from a team January 16, 2024 09:08
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d487a11) 79.40% compared to head (361a7c1) 82.12%.
Report is 2 commits behind head on main.

Files Patch % Lines
nucliadb/nucliadb/search/search/summarize.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1731      +/-   ##
==========================================
+ Coverage   79.40%   82.12%   +2.72%     
==========================================
  Files         334      334              
  Lines       19550    19602      +52     
==========================================
+ Hits        15523    16099     +576     
+ Misses       4027     3503     -524     
Flag Coverage Δ
ingest 69.05% <ø> (-0.09%) ⬇️
nucliadb 70.39% <80.00%> (+4.70%) ⬆️
sdk 40.58% <ø> (ø)
search 79.04% <40.00%> (-0.06%) ⬇️
writer 85.15% <ø> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran merged commit 14ca50a into main Jan 16, 2024
81 checks passed
@lferran lferran deleted the add-summarize-to-sdk branch January 16, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants