Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration to upgrade relations and texts to v2 #1732

Conversation

jotare
Copy link
Contributor

@jotare jotare commented Jan 16, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@jotare jotare requested a review from a team January 16, 2024 11:56
Copy link

This pull request has been linked to Shortcut Story #8057: Script/migration to remove old relations index.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d487a11) 79.40% compared to head (0c434f6) 82.24%.
Report is 2 commits behind head on main.

Files Patch % Lines
...grations/0007_upgrade_relations_and_texts_to_v2.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1732      +/-   ##
==========================================
+ Coverage   79.40%   82.24%   +2.84%     
==========================================
  Files         334      335       +1     
  Lines       19550    19738     +188     
==========================================
+ Hits        15523    16233     +710     
+ Misses       4027     3505     -522     
Flag Coverage Δ
ingest 69.05% <ø> (-0.09%) ⬇️
nucliadb 70.40% <80.00%> (+4.71%) ⬆️
reader 79.02% <ø> (ø)
sdk 40.58% <ø> (ø)
train 63.71% <ø> (-0.17%) ⬇️
utils 81.25% <ø> (ø)
writer 85.15% <ø> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotare jotare merged commit 4b7ab33 into main Jan 18, 2024
71 checks passed
@jotare jotare deleted the joanantoniriera4168/sc-8057/script-migration-to-remove-old-relations branch January 18, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants