Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing field #1756

Merged
merged 1 commit into from
Jan 23, 2024
Merged

add missing field #1756

merged 1 commit into from
Jan 23, 2024

Conversation

vangheem
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb64448) 82.11% compared to head (85f90e5) 82.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1756   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files         336      336           
  Lines       19674    19674           
=======================================
  Hits        16156    16156           
  Misses       3518     3518           
Flag Coverage Δ
ingest 69.07% <ø> (ø)
nucliadb 70.21% <ø> (ø)
reader 79.05% <ø> (ø)
sdk 40.58% <ø> (ø)
search 79.00% <ø> (ø)
train 63.71% <ø> (ø)
utils 81.42% <ø> (ø)
writer 85.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vangheem vangheem merged commit 88e7437 into main Jan 23, 2024
74 of 77 checks passed
@vangheem vangheem deleted the add-field branch January 23, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants