Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug logs for notifications #1812

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Feb 8, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@lferran lferran requested a review from a team February 8, 2024 10:04
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (440ed1b) 82.17% compared to head (c71fa02) 82.17%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1812      +/-   ##
==========================================
- Coverage   82.17%   82.17%   -0.01%     
==========================================
  Files         338      338              
  Lines       19744    19744              
==========================================
- Hits        16225    16224       -1     
- Misses       3519     3520       +1     
Flag Coverage Δ
ingest 70.06% <ø> (ø)
nucliadb 70.28% <ø> (-0.01%) ⬇️
reader 80.72% <ø> (ø)
sdk 40.58% <ø> (ø)
standalone 87.79% <ø> (ø)
train 63.60% <ø> (ø)
utils 81.62% <ø> (ø)
writer 85.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran merged commit 57df743 into main Feb 8, 2024
75 checks passed
@lferran lferran deleted the add-warning-on-non-consumed-notifications branch February 8, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants