Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest - use defined SA name in purgeCron RBAC #1850

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

zepellin
Copy link
Contributor

Description

Uses K8s service account defined in the values in purge cron role binding

@CLAassistant
Copy link

CLAassistant commented Feb 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (513ac01) 84.28% compared to head (7989e89) 83.95%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1850      +/-   ##
==========================================
- Coverage   84.28%   83.95%   -0.33%     
==========================================
  Files         328      328              
  Lines       18856    19025     +169     
==========================================
+ Hits        15892    15972      +80     
- Misses       2964     3053      +89     
Flag Coverage Δ
ingest 70.27% <ø> (+0.09%) ⬆️
sdk 87.85% <ø> (ø)
utils 81.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zepellin zepellin changed the title Ingress - use defined SA name in purgeCron RBAC Ingest - use defined SA name in purgeCron RBAC Feb 19, 2024
@zepellin zepellin merged commit 5a9ed31 into main Feb 19, 2024
71 checks passed
@zepellin zepellin deleted the purge-cron-rbac-sa branch February 19, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants