-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not scan_keys on getting labelsets #1863
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1863 +/- ##
==========================================
- Coverage 84.35% 84.34% -0.02%
==========================================
Files 328 328
Lines 18757 18747 -10
==========================================
- Hits 15823 15812 -11
- Misses 2934 2935 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
[sc-8994] |
This pull request has been linked to Shortcut Story #8994: reduce tikv scans. |
Description
Current implementation of getting labelsets uses tikv scan keys to get the list of labelsets.
Tikv doesn't behave very well when scanning keys.
This PR does:
How was this PR tested?
Integration tests