Scan keys less often on ingest #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1868 +/- ##
==========================================
- Coverage 84.34% 84.30% -0.04%
==========================================
Files 328 328
Lines 18747 18747
==========================================
- Hits 15812 15805 -7
- Misses 2935 2942 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
[sc-8994] |
|
This pull request has been linked to Shortcut Story #8994: reduce tikv scans. |
lferran
commented
Feb 22, 2024
| # Get all fields | ||
| if len(self.all_fields_keys) == 0 or force: |
There was a problem hiding this comment.
This was a bug: resources that had no fields would fetching the fields ids list no matter what
lferran
commented
Feb 22, 2024
Comment on lines
-647
to
-651
| # backward compatibility if all fields key is not set | ||
| all_fields = PBAllFieldIDs() | ||
| async for (field_type, field_id) in self._scan_fields_ids(): | ||
| result.append((field_type, field_id)) | ||
| all_fields.fields.append(FieldID(field_type=field_type, field=field_id)) |
There was a problem hiding this comment.
this bw/compatible code can be removed, as the migration ran in prod long time ago.
I've checked in stage and all fields ids keys match with the correct number of fields
jotare
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scanning of keys to get field ids is no longer needed (a migration was run log time ago), as we are materializing the list of field ids in a separate key in the KV store.
This will reduce the amount of scan_keys that we do to tikv, who doesn't seem to be very happy.
How was this PR tested?
Existing tests should cover. I also tested agains stage to check that all field ids keys correspond to the valid list of fields.