Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BucketNotEmpty as S3 string error codes #1878

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

jotare
Copy link
Contributor

@jotare jotare commented Feb 23, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@jotare jotare requested a review from a team February 23, 2024 16:12
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (9fa8194) to head (07904e2).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1878      +/-   ##
==========================================
- Coverage   84.34%   83.98%   -0.37%     
==========================================
  Files         328      328              
  Lines       18747    18972     +225     
==========================================
+ Hits        15812    15933     +121     
- Misses       2935     3039     +104     
Flag Coverage Δ
ingest 69.46% <ø> (-0.29%) ⬇️
sdk 87.85% <ø> (ø)
utils 81.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotare jotare merged commit 7239116 into main Feb 23, 2024
79 checks passed
@jotare jotare deleted the fix-s3-bucket-not-empty-unparsable-error branch February 23, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants