Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rollover twice #1889

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Do not rollover twice #1889

merged 2 commits into from
Feb 26, 2024

Conversation

vangheem
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.89%. Comparing base (e67127e) to head (f5ab1f2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1889   +/-   ##
=======================================
  Coverage   83.89%   83.89%           
=======================================
  Files         328      328           
  Lines       18695    18693    -2     
=======================================
- Hits        15684    15683    -1     
+ Misses       3011     3010    -1     
Flag Coverage Δ
ingest 68.81% <ø> (ø)
sdk 87.85% <ø> (ø)
utils 81.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vangheem vangheem closed this Feb 26, 2024
@vangheem vangheem reopened this Feb 26, 2024
@vangheem vangheem merged commit 99d01b2 into main Feb 26, 2024
123 of 130 checks passed
@vangheem vangheem deleted the rollover-again branch February 26, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants