Simplify kb and shard creation #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: fc46b23 | Previous: d4afd82 | Ratio |
|---|---|---|---|
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error |
13558.105377262455 iter/sec (stddev: 1.512755057350271e-7) |
13028.533525895236 iter/sec (stddev: 4.192637045977425e-7) |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
lferran
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
release_channelwas stored duplicated inKnowledgeBoxConfigandShards, deprecate the one inKnowledgeBoxConfigcreate_shard_by_kbidhad logic for the first shards. Move it toKnowledgeBox.create. This allows to simplify the signature and avoid passingsemantic_model(ignored) andrelease_channel(overwritten) every time we create a shardHow was this PR tested?
Existing tests