Be able to index a resource by storage referece #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 728443a | Previous: 1a9ce6c | Ratio |
|---|---|---|---|
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error |
7770.0872950681505 iter/sec (stddev: 1.9786275859340796e-7) |
13339.058637295573 iter/sec (stddev: 1.296413027597777e-7) |
1.72 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: d6ad4f9 | Previous: d4afd82 | Ratio |
|---|---|---|---|
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error |
7619.282909228837 iter/sec (stddev: 1.660689890135406e-7) |
13028.533525895236 iter/sec (stddev: 4.192637045977425e-7) |
1.71 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2094 +/- ##
==========================================
- Coverage 82.09% 74.78% -7.32%
==========================================
Files 42 80 +38
Lines 2346 5945 +3599
==========================================
+ Hits 1926 4446 +2520
- Misses 420 1499 +1079
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lferran
changed the title
|
[sc-9954] |
hermeGarcia
suggested changes
Apr 29, 2024
hermeGarcia
approved these changes
Apr 29, 2024
lferran
force-pushed
the
poc-node-download-resource-from-object-storage
branch
from
94d083f
to
d0f1e65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This way we can have sidecar indexing on more KBs at the same time than now because memory is a problem as we have to load the resources in memory.
How was this PR tested?
Describe how you tested this PR.