Skip to content

Commit

Permalink
Fix missing secretName value (#1505)
Browse files Browse the repository at this point in the history
  • Loading branch information
liranbg committed Feb 13, 2020
1 parent d7a3d2d commit d9216ae
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
10 changes: 10 additions & 0 deletions hack/k8s/helm/nuclio/templates/NOTES.txt
@@ -0,0 +1,10 @@
1. Get the application URL by running these commands:
{{- if .Values.dashboard.ingress.enabled }}
{{- range .Values.dashboard.ingress.hosts }}
http{{ if $.Values.dashboard.ingress.tls }}s{{ end }}://{{ . }}{{ $.Values.dashboard.ingress.path }}
{{- end }}
{{- else }}
export POD_NAME=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "nuclio.io/app=dashboard" -o jsonpath="{.items[0].metadata.name}")
echo "Visit http://localhost:8070 to use nuclio"
kubectl -n {{ .Release.Namespace }} port-forward $POD_NAME 8070:8070
{{- end }}
2 changes: 1 addition & 1 deletion hack/k8s/helm/nuclio/values.yaml
Expand Up @@ -91,7 +91,7 @@ registry:
# | sed s/"namespace: <source-namespace>"/"namespace: <destination-namespace>"/ \
# | kubectl apply -n <destination-namespace> -f -
#
# secretName: registry-credentials
secretName: registry-credentials

# In some cases the docker server URL in the registry secrets isn't the same as the URL with which
# you push and pull. For example, in GKE you login to `gcr.io` (or some other regional URL) yet have
Expand Down

0 comments on commit d9216ae

Please sign in to comment.