Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cron job fixes #1735

Merged
merged 7 commits into from Jul 2, 2020
Merged

Cron job fixes #1735

merged 7 commits into from Jul 2, 2020
+22 −4

Conversation

sahare92
Copy link
Contributor

@sahare92 sahare92 commented Jul 1, 2020

Cron job fixes.

Changes:

  • Changed "cronJobStalePodsDeletionInterval" to be 1min instead of 10min (prevent many stale pods running on the system)
  • Limit job history to 1 (makes kube jobs api clearer)
  • Added jobBackoffLimit to cron trigger spec. Limiting the number of retries before failing a job (defaults to 2, to reduce stress on the system - relevant especially for triggers with low cron interval)
  • Fix - prevent functionPods List from selecting cron-job pods

liranbg
liranbg requested changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@liranbg liranbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!
minor comment below

@liranbg liranbg merged commit e65528d into nuclio:development Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranbg liranbg liranbg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sahare92 @liranbg