[Bugfix]: Shell runtime execution with security context #1862
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shell runtime would need to
chmod
the run script to give it execute permissions.If a security context is given, this fails.
Added a check to see if the handler is a script in the current working directory or a command from the PATH.
If it is a command, it is run with
sh -c
If not, it is run with
sh
(without-c
) which results insh
reading the file as a script and running it, so there's no need tochmod
the file.Benchmarked the changes in the event processing function to ensure no large loss of performance happens because of the string manipulations. The performance change is negligible.