Renamed apigateway ingress resources to prefixed with nuclio #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranbg
changed the title
sahare92
suggested changes
Nov 3, 2020
There was a problem hiding this comment.
Good job!
Please also change the resource name here: (the generated secret in case of basic-auth)
https://github.com/nuclio/nuclio/blob/development/pkg/platform/kube/apigatewayres/lazy.go#L263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefixed apigateway to start with
nuclioto aligned with all nuclio kubernetes managed resourcesShorthanded apigateway to
agwto avoid name too long and kept it in to relate ingress name to apigateway feature