Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Don't populate function source code for all code entry types #3088

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

TomerShor
Copy link
Contributor

When building a function from a file path, the file contents are copied to the functionSourceCode attribute so it can be used when building an image.

In cases where the codeEntryType is not sourceCode , e.g when deploying a function from git, the source code is not needed in the function spec for the image to be built properly, and it is better for security and privacy to not expose the source code in such cases.

Resolves #3084

Copy link
Contributor

@rokatyy rokatyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TomerShor TomerShor merged commit 06f7118 into nuclio:development Dec 13, 2023
11 checks passed
@TomerShor TomerShor deleted the git-test branch December 13, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: codeEntryType: git - sourcecode in yaml-file after exporting
2 participants