Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nuctl] Autofix function import failure #3112

Merged
merged 8 commits into from
Jan 9, 2024
Merged

[Nuctl] Autofix function import failure #3112

merged 8 commits into from
Jan 9, 2024

Conversation

rokatyy
Copy link
Contributor

@rokatyy rokatyy commented Jan 8, 2024

This PR is a part of https://jira.iguazeng.com/browse/NUC-118

It enables the ability to automatically fix known issues on the nuctl side if any occur.

@rokatyy rokatyy requested a review from TomerShor January 8, 2024 13:34
@rokatyy rokatyy marked this pull request as ready for review January 8, 2024 13:34
@github-actions github-actions bot added the nuctl label Jan 8, 2024
TomerShor
TomerShor requested changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@TomerShor TomerShor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, gave some suggestions for improvement.
The suggested new functions for dealing with fixes and the error constants can be a part of the functionconfig package and not specifically in import.go.

pkg/nuctl/command/import.go Outdated Show resolved Hide resolved
pkg/nuctl/command/import.go Outdated Show resolved Hide resolved
pkg/nuctl/command/import.go Show resolved Hide resolved
@rokatyy rokatyy requested a review from TomerShor January 8, 2024 16:09
TomerShor
TomerShor requested changes Jan 8, 2024
View reviewed changes
pkg/nuctl/command/import.go Outdated Show resolved Hide resolved
pkg/nuctl/command/import.go Outdated Show resolved Hide resolved
pkg/nuctl/command/import.go Outdated Show resolved Hide resolved
pkg/nuctl/command/import.go Outdated Show resolved Hide resolved
@rokatyy rokatyy requested a review from TomerShor January 8, 2024 16:34
TomerShor
TomerShor requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@TomerShor TomerShor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a test for it.
see functionExportImportTestSuite

pkg/nuctl/command/import.go Outdated Show resolved Hide resolved
pkg/nuctl/command/import.go Outdated Show resolved Hide resolved
TomerShor
TomerShor approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@TomerShor TomerShor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Minor comment but approved :)

pkg/nuctl/test/function_test.go Outdated Show resolved Hide resolved
pkg/nuctl/test/function_test.go Outdated Show resolved Hide resolved
@TomerShor TomerShor merged commit 1448b28 into nuclio:development Jan 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomerShor TomerShor TomerShor approved these changes

Assignees
No one assigned
Labels
nuctl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rokatyy @TomerShor