Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTTP] Handle internal healthcheck before request validation #3118

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

TomerShor
Copy link
Contributor

@TomerShor TomerShor commented Jan 10, 2024

Kubernetes health check requests do not have any headers (specifically - no Origin header), and are very frequent.
When CORS is enabled, these checks fail CORS origin validation and keep the trigger constantly busy so every request gets redirected.

Fixes https://jira.iguazeng.com/projects/NUC/issues/NUC-5

Copy link
Contributor

@quaark quaark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@liranbg liranbg merged commit 1582905 into nuclio:development Jan 11, 2024
11 checks passed
@TomerShor TomerShor deleted the bugfix/NUC-5 branch January 16, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants