-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Local] Allow disabling port publishing on host network #3127
[Local] Allow disabling port publishing on host network #3127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question regarding implementation. Annotation part looks good to me.
Also - maybe it is worth covering this in our docs? (For instance, here)
@rokatyy Yes, once we go on a specific way to set it up I'll add it do the docs, not development docs but rather function configuration docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Just 2 minor suggestion :)
Currently we do not have an option for local (docker) environments to disable publishing the function container port on the host network. The only options are to select a specific port or a a random port.
This can cause possible security issues for users who do not want to expose their function on external URLs.
In this PR I've added to option to avoid publishing the function on the host network using the trigger attributes, which can be set in the function spec as follows:
Until this feature will be enabled in the GUI as well, this can also be set via trigger annotations, with the followin annotation:
Note - this is already supported in a Kubernetes environment.
Resolves #2468