-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nuctl] Introduce nuctl parse #3129
Conversation
@rokatyy please add an example output in the description as well. |
pkg/nuctl/command/parse.go
Outdated
|
||
cmd.Flags().StringVar(&commandeer.reportFilePath, "report-file-path", "nuctl-import-report.json", "Path to report") | ||
cmd.Flags().BoolVar(&commandeer.onlyFailed, "failed", false, "Show only failures") | ||
cmd.Flags().StringVarP(&commandeer.outputPath, "output-path", "", "", "Path to save outputPath") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmd.Flags().StringVarP(&commandeer.outputPath, "output-path", "", "", "Path to save outputPath") | |
cmd.Flags().StringVarP(&commandeer.outputPath, "output-path", "", "", "File path to save the parsed report") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also - if parent folder doesn't exist it will fail. perhaps worth mentioning it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomerShor we raise a warning in that case
…report # Conflicts: # pkg/nuctl/command/common/importreport.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Jira - https://jira.iguazeng.com/browse/NUC-129
This PR introduces new nuctl command -
nuctl parse
It is intended to parse any type that implements
Report
interface. In other words, for now it supports import functions/projects reports.Usage example:
Output example: