Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Platform] Move function name validation from resource to platform" #3133

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

TomerShor
Copy link
Contributor

Reverts #3130

This failed the CI on several tests, and the reason being that if a function is deployed from a function configuration file (or URL), the config is read in the Build part of the deployment which happens after the enrichment/validation.
Until we move the configuration reading earlier, I'm reverting this change.

@TomerShor TomerShor merged commit 4c40528 into development Jan 23, 2024
11 checks passed
@TomerShor TomerShor deleted the revert-3130-bugfix/validate-func-name branch January 23, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants