[Dashboard] Support email in username label #3149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranbg
approved these changes
Jan 29, 2024
TomerShor
requested changes
Jan 29, 2024
Co-authored-by: TomerShor <90552140+TomerShor@users.noreply.github.com>
TomerShor
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a Nuclio function in Iguazio, a function label is created:
iguazio.com/username: <username>Following the SSO effort, we need to allow usernames that looks like an email, e.g:
name@nuclio.comThe issue is that the
@sign is an invalid character in a kubernetes label.To resolve this issue, in case we encounter an email-like username, we will split it into 2 labels, e.g.:
Jira - https://jira.iguazeng.com/browse/NUC-133