[Processor] Add a control message to inform the processor that draining is done #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerShor
requested changes
Feb 1, 2024
TomerShor
requested changes
Feb 1, 2024
TomerShor
approved these changes
Feb 1, 2024
TomerShor
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, we lack a signaling mechanism to notify the processor when draining is complete. Currently, the processor relies on a timeout, which is not the most efficient approach. Even if draining takes less than a second, we still wait for around 10 seconds.
To address this issue, we are introducing a new control message -
DrainDoneMessageKind. This message allows the wrapper to inform the processor when draining is done.Jira - https://jira.iguazeng.com/browse/NUC-124