[Processor] Do not close kafka connection if workers are terminated #3159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug where some messages were processed twice after a function restart. The issue arose because, after sending a termination signal, all workers were marked as terminated. Subsequently, when the
ConsumeClaim
function attempted to allocate a worker, it encountered an error, causing the consumption loop to break and, consequently, halting theexplicitAckHandler
. As a result, the processor side could no longer respond to control messages from the runtime side, as evidenced in the log with the message:"Failed to read control message","more":{"errRootCause":"EOF"}}
.This PR modifies this behavior so that the consumption loop does not break upon receiving the
ErrAllWorkersAreTerminated
error.Jira - https://jira.iguazeng.com/browse/NUC-139