[Processor] Do not break wrapper loop on termination #3163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… have enough time to finish control messages processing
TomerShor
approved these changes
Feb 8, 2024
liranbg
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns wrapper's behaviour for termination with the drain's one. So, we won't break a serving loop after termination, but will discard all events which come afterwards. The reason for this is the conditions when we want to stop waiting for full termination. One of those conditions should be met: runtime is stopped OR waiting timeout is passed. If the runtime exits right after sending an
ExplicitAckcontrol message, then the processor might not have enough time to process control messages which leads to processing same messages twice.