[Controller] Set function status to unhealthy instead of error during fast-fail check
#3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is in CrashLoopBack or has scheduling issues (not enough resources)
rokatyy
changed the title
rokatyy
changed the title
rokatyy
changed the title
rokatyy
changed the title
TomerShor
requested changes
Feb 19, 2024
docs/reference/function-configuration/function-configuration-reference.md
Outdated
Show resolved
Hide resolved
docs/reference/function-configuration/function-configuration-reference.md
Outdated
Show resolved
Hide resolved
docs/reference/function-configuration/function-configuration-reference.md
Outdated
Show resolved
Hide resolved
docs/reference/function-configuration/function-configuration-reference.md
Outdated
Show resolved
Hide resolved
jillnogold
reviewed
Feb 19, 2024
docs/reference/function-configuration/function-configuration-reference.md
Outdated
Show resolved
Hide resolved
TomerShor
requested changes
Feb 19, 2024
docs/reference/function-configuration/function-configuration-reference.md
Outdated
Show resolved
Hide resolved
docs/reference/function-configuration/function-configuration-reference.md
Outdated
Show resolved
Hide resolved
TomerShor
requested changes
Feb 21, 2024
pkg/platform/kube/platform.go
Outdated
Comment on lines
264
to
266
| // low severity to not over log in the warning | ||
| createFunctionOptions.Logger.DebugWithCtx(ctx, "Function creation failed, brief error message extracted", | ||
| "briefErrorsMessage", briefErrorsMessage) |
There was a problem hiding this comment.
leave this log, with the brief error message (will only be visible in the pod logs)
pkg/platform/kube/platform.go
Outdated
| @@ -290,6 +283,14 @@ func (p *Platform) CreateFunction(ctx context.Context, createFunctionOptions *pl | |||
| } | |||
| } | |||
|
|
|||
| if functionStatus.State == functionconfig.FunctionStateUnhealthy { | |||
| createFunctionOptions.Logger.WarnWithCtx(ctx, "Function deployment failed, setting state to unhealthy. The issue might be transient or require manual redeployment", | |||
| "briefErrorsMessage", briefErrorsMessage) | |||
There was a problem hiding this comment.
Suggested change
| "briefErrorsMessage", briefErrorsMessage) | |
| "err", errorStack.String()) |
TomerShor
changed the title
unhealthy instead of error during fast-fail check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses pretty old bug where we set function to error state within the fast-fail controller's mechanism because of either CrashLoop or scheduling issues. So, we could end up with working and healthy function stacked in error state forever, because our approach to Nuclio states assumes that
errorstate is a permanent state which can not be changed per time. Whileunhealthystate is a state that we monitor with FunctionMonitor component, so it is changeable. In light of this, we decided to set function tounhealthystate in case of any of above described errors occurred.Also,
resolveFailFastfunction returns not only error, but also a status to which controller should set the function in case of error. For now, we only set function tounhealthystate here, but we plan to add more checks, so this change provides a flexibly for future changes.Jira - https://jira.iguazeng.com/browse/NUC-26
[SOLVED - Have decided to change a
warnlog message to show the difference betweenerrorandunhealthystates]Question: it is crucial to say that if function is unhealthy, we will anyway (with current logic) set the
status.Logsso that user can understand what the problem is. Taking into account the fact thatunhealthystatus is monitored byFunctionMonitorwe should consider what will happen with the function if it is fixed and is set toreadystate. Maybe it worth cleaning upstatus.logson that case?Example:
unhealthy