[Project] Filter invalid labels if creating project from leader request #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerShor
added a commit
to TomerShor/nuclio
that referenced
this pull request
Feb 18, 2024
…st (nuclio#3168) # Conflicts: # pkg/common/k8s.go # pkg/platform/abstract/platform.go # pkg/platform/kube/test/platform_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new project is created in the leader, it sends a POST request to Nuclio to create the project, instead of relying on Nuclio's synchronization mechanism.
Since currently the leaders allow for project labels that are invalid in k8s, we want to just ignore those labels when we receive a create project request from the leader.
Note: these labels are already filtered in the synchronization mechanism (see #2794).
In addition, some more improvements regarding this flow:
Creating projectslogs a bit for a better debugging experience.