Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Update archiver package #3189

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Conversation

TomerShor
Copy link
Contributor

Due to a recently found security vulnerability in the github.com/mholt/archiver/v3 package, this PR updates the package to the v4.0.0-alpha.8 version.

The v4 version introduced usage changes and requires some more involved code wrt to extracting archives.

Copy link
Contributor

@quaark quaark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, sorry for the refactor 😅

pkg/processor/build/util/decompress.go Outdated Show resolved Hide resolved
pkg/processor/build/util/decompress.go Outdated Show resolved Hide resolved
pkg/processor/build/util/decompress_test.go Outdated Show resolved Hide resolved
@TomerShor TomerShor marked this pull request as ready for review March 6, 2024 06:54
Copy link
Contributor

@rokatyy rokatyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

Copy link
Contributor

@quaark quaark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I'm not sure about the jar handling but that isn't a showstopper

pkg/processor/build/util/unarchive.go Show resolved Hide resolved
@TomerShor TomerShor merged commit 2ac3c66 into nuclio:development Mar 7, 2024
11 checks passed
@TomerShor TomerShor deleted the sec/archives branch March 7, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants