[Misc] Fix the error json: unsupported value: encountered a cycle via
#3208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerShor
reviewed
Apr 7, 2024
liranbg
changed the title
json: unsupported value: encountered a cycle viajson: unsupported value: encountered a cycle via
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira - https://iguazio.atlassian.net/browse/NUC-163
This PR fixes a bug where we see
json: unsupported value: encountered a cycle viain the log. The culprit is this line:p.logger.DebugWith("Starting triggers", "triggers", p.triggers). Here,p.triggersis of type[]Trigger, where Trigger is an interface. Each trigger in the list is a child of anAbstractTrigger. EachAbstractTriggermaintains a pointer to the original child trigger.So here is a loop. Hence, this log line itself is the reason we encounter this error. The logger was unable to encode the object into JSON.