[Platform] Add platform configuration to merge platform's default node selectors with project's node selectors #3215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with project's node selectors. Default behavior changed to take platform's only if project's ones aren't set.
TomerShor
reviewed
Apr 14, 2024
TomerShor
requested changes
Apr 15, 2024
TomerShor
reviewed
Apr 16, 2024
Co-authored-by: TomerShor <90552140+TomerShor@users.noreply.github.com>
TomerShor
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior has been modified to consider the platform's NodeSelectors only if the project's NodeSelectors are not set. This adjustment aims to synchronize MLRun's logic with Nuclio's. Despite altering the default behavior, this pull request aims to provide users with the option to re-enable the merging logic.
Jira - https://iguazio.atlassian.net/browse/NUC-171