[Controller] Allow multiple gateways assigned to one Nuclio function #3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranbg
approved these changes
Apr 16, 2024
TomerShor
reviewed
Apr 16, 2024
TomerShor
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it’s not allowed to have multiple gateways assigned to one Nuclio function. However, it still can be the case for user to have gateway with authorization on top of one function and canary and auth on top of same function + additional Nuclio function.
Since stress test on having multiple gateways assigned to the same Nuclio function is successfully passed, we can get rid of this limitation.
Jira - https://iguazio.atlassian.net/browse/NUC-167