Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform] Fix default http trigger enrichment #3219

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

rokatyy
Copy link
Contributor

@rokatyy rokatyy commented Apr 17, 2024

This PR fixes the enrichment of disableDefaultHTTPTrigger configuration. The original PR which implemented this functionality had some parts left only for platform configuration enrichment and as a result there are some code parts left misaligned with function configuration.

Copy link
Contributor

@liranbg liranbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add pr description with reasoning ?

@rokatyy
Copy link
Contributor Author

rokatyy commented Apr 17, 2024

@liranbg added

@rokatyy rokatyy marked this pull request as ready for review April 17, 2024 15:30
@TomerShor TomerShor merged commit cb346e7 into nuclio:development Apr 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants