[Scrubber] API Gateway config scrubbing #3225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ployer functionality in order to make evething as agnostic as possible
…ployer functionality in order to make evething as agnostic as possible
github-actions
bot
added
platform/kube
platform/local
nuctl
configuration
platform
labels
rokatyy
changed the title
TomerShor
requested changes
Apr 21, 2024
TomerShor
reviewed
Apr 21, 2024
rokatyy
changed the title
TomerShor
requested changes
Apr 25, 2024
TomerShor
requested changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to implement configuration scrubbing for API gateways, allowing sensitive data to be stored in a Kubernetes secret instead of directly in the CRD. While we already had scrubbing logic in place, it was specific to function configuration. This PR introduces an abstract interface and scrubber struct, making it easier to inherit and use them in the future if needed. Additionally to this, all the scrubbing logic which had been in platform/deployer was moved under scrubber to be more consistent, keep scrubbing in one place and avoid code duplications.
Also, in order to support masking sensitive fields when creating API Gateway via
nuctl, new flag--mask-sensitive-fieldswas added. Default behaviour is not to mask, because we want to keep backward compatibility.Jira - https://iguazio.atlassian.net/browse/NUC-170, part of https://iguazio.atlassian.net/browse/NUC-114