[EPIC] New fee model architecture #270
Open
+3,791
−1,717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wip: change of plans was a mistakerino
`ManagedAllowList`
Co-authored-by: Manuel Montenegro <manuel@nucypher.com>
Extract fees logic from Coordinator
BqETH subscription (no encryptor fees yet)
Co-authored-by: David Núñez <david@nucypher.com>
Encryptor fees and slots management in subscription
General improvements for Subscription
vzotova
changed the title
vzotova
requested review from
KPrasch,
arjunhassard,
cygnusv,
theref,
derekpierre,
manumonti and
piotr-roslaniec
derekpierre
reviewed
Jun 27, 2024
There was a problem hiding this comment.
Looks like we will need some nucypher updates to accommodate the new architecture. Filed nucypher/nucypher#3514.
contracts/contracts/coordination/subscription/BqETHSubscription.sol
Outdated
Show resolved
Hide resolved
Comment on lines
+107
to
+115
| return 42 * 10 ** 20; // TODO | ||
| } | ||
|
|
||
| /** | ||
| * @notice Returns the base expiration duration | ||
| * @return The base expiration duration | ||
| */ | ||
| function baseExpiration() public pure returns (uint256) { | ||
| return 52 weeks; // TODO |
There was a problem hiding this comment.
Do these "TODOs" still need to be revisited?
There was a problem hiding this comment.
I plan to remove Subscription contract when ManagedAllowList will be integrated with new Subscription
Co-authored-by: Derek Pierre <derek.pierre@gmail.com>
vzotova
force-pushed
the
epic-subscription
branch
from
8e7bb18
to
3886874
Compare
Follow up PR: Removes BetaProgramInitiator, Global is Global, return backward compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Changes fee model, now it's separate contract that must be approved in coordinator.
Implements subscription for BqETH
Issues fixed/closed:
Why it's needed:
Notes for reviewers:
This PR is ready for tests and integration with nucypher repo, ManagedAllowList needs touch up in some of following PRs