Adds fee model <-> allow list communication #271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Manuel Montenegro <manuel@nucypher.com>
vzotova
requested review from
arjunhassard,
cygnusv,
theref,
derekpierre and
manumonti
arjunhassard
approved these changes
May 24, 2024
| state == Coordinator.RitualState.DKG_TIMEOUT || | ||
| state == Coordinator.RitualState.DKG_INVALID | ||
| ) { | ||
| // Refund everything minus cost of renting cohort for a day |
There was a problem hiding this comment.
As mentioned in the call we don't need a fully functioning refund system in the first version but fine to have this here for later
| require(msg.sender == address(coordinator), "Only coordinator can call process payment"); | ||
| uint256 ritualCost = getRitualInitiationCost(numberOfProviders, duration); | ||
| require(ritualCost > 0, "Invalid ritual cost"); | ||
| totalPendingFees += ritualCost; |
There was a problem hiding this comment.
does this balance cover encryptor credits and the base fee?
There was a problem hiding this comment.
this is initial fee model, not yet subscription. so no credits or base fee, just flat rate
Co-authored-by: David Núñez <david@nucypher.com>
7 tasks
derekpierre
approved these changes
Jun 7, 2024
| @@ -12,7 +12,26 @@ interface IFeeModel { | |||
| function currency() external view returns (IERC20); | |||
|
|
|||
| function getRitualInitiationCost( | |||
| address[] calldata providers, | |||
| uint256 numberOfProviders, | |||
Co-authored-by: Derek Pierre <derek.pierre@gmail.com>
|
Considering many follow up changes, skip this as separate PR and review directly #272 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Adds calls to fee model from allow list. Small PR but finishes (I hope) basic architecture of communication
Issues fixed/closed:
Refs #264
Why it's needed:
Notes for reviewers:
Based on #265