Fix missing provider_uri #2626
Fix missing provider_uri #2626
Conversation
| @@ -69,7 +69,7 @@ | |||
|
|
|||
| # Then, there was bob. Bob learns about the | |||
| # rest of the network from the seednode. | |||
| bob = Bob(domain=TESTNET) | |||
| bob = Bob(domain=TESTNET, provider_uri=PROVIDER_URI) | |||
There was a problem hiding this comment.
As a design goal, Bob can operate entirely offchain without an ethereum provider connection. If this is a required parameter, we'll need to take a deeper look and make it optional!
nucypher/characters/base.py
Outdated
| @@ -84,6 +84,7 @@ def __init__(self, | |||
| signer: Signer = None, | |||
| registry: BaseContractRegistry = None, | |||
| include_self_in_the_state: bool = False, | |||
| is_offchain: bool = False, | |||
There was a problem hiding this comment.
Hmm - this kwarg becomes a bit superfluous IMO since it doesn't affect any other character's construction. Alternately, I suggest relocating provider_uri into each Character subclass init.
There was a problem hiding this comment.
But because Bob is the only character that works without provider_uri we still want to raise ValueError('Provider URI is required to init a decentralized character.') in the character's respective init, correct?
There was a problem hiding this comment.
Yes, I that's what I'm thinking! 👍🏻
Type of PR:
Bugfix
Required reviews:
1
What this does:
Fixes
ValueError: Provider URI is required to init a decentralized character.thrown onBob()andAlice()constructors.