Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Infura Provider Support #1059

Closed
wants to merge 3 commits into from
Closed

Basic Infura Provider Support #1059

wants to merge 3 commits into from

Conversation

KPrasch
Copy link
Member

@KPrasch KPrasch commented Jun 7, 2019

Based on #948

@KPrasch KPrasch added Enhancement New or improved features Configuration Node configuration labels Jun 7, 2019
@KPrasch KPrasch requested a review from vepkenez June 7, 2019 15:51
@codecov
Copy link

codecov bot commented Jun 7, 2019 •
edited

Codecov Report

Merging #1059 into master will decrease coverage by 0.05%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
- Coverage   83.48%   83.43%   -0.06%     
==========================================
  Files          72       72              
  Lines        9745     9772      +27     
==========================================
+ Hits         8136     8153      +17     
- Misses       1609     1619      +10
Impacted Files Coverage Δ
nucypher/blockchain/eth/interfaces.py 80.58% <100%> (+0.14%) ⬆️
nucypher/blockchain/eth/registry.py 76.06% <100%> (+0.2%) ⬆️
nucypher/blockchain/eth/providers.py 45.45% <20%> (-1.61%) ⬇️
nucypher/blockchain/eth/clients.py 58.57% <85.18%> (+1.52%) ⬆️
nucypher/blockchain/eth/token.py 85.95% <0%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47b9c12...8b1dd1d. Read the comment docs.

@KPrasch KPrasch force-pushed the infura branch 2 times, most recently from 1737e36 to cee7052 Compare June 9, 2019 20:23
@vepkenez vepkenez marked this pull request as ready for review June 13, 2019 10:02
@vepkenez
Copy link
Contributor

oops I didn't mean to take this out of "draft"... no way to put it back!

@KPrasch KPrasch changed the title Infura Provider Support [WIP] Infura Provider Support Jun 14, 2019
vepkenez
vepkenez requested changes Jun 14, 2019
View reviewed changes
nucypher/blockchain/eth/clients.py Outdated Show resolved Hide resolved
@KPrasch KPrasch requested a review from vepkenez July 17, 2019 03:21
@KPrasch KPrasch changed the title [WIP] Infura Provider Support Basic Infura Provider Support Jul 18, 2019
michwill
michwill approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@michwill michwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However, should it go to master or the epic?
Anyway, once we've got the recent staking epic in, we can test using infura for real

@vepkenez vepkenez force-pushed the infura branch 2 times, most recently from b89111b to 20bdac6 Compare July 30, 2019 21:21
@KPrasch
Copy link
Member Author

KPrasch commented Aug 6, 2019

Combined with #1071

@KPrasch KPrasch closed this Aug 6, 2019
@KPrasch KPrasch deleted the infura branch March 22, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepkenez vepkenez vepkenez approved these changes

@michwill michwill michwill approved these changes

Assignees

@vepkenez vepkenez

@KPrasch KPrasch

Labels
Configuration Node configuration Enhancement New or improved features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KPrasch @vepkenez @michwill