Status page fixes #2378
Status page fixes #2378
Conversation
Take this node's fleet state from `known_nodes` instead of the variables set in `update_snapshot`
| @@ -184,7 +196,7 @@ ${fleet_state_icon(state.checksum, state.nickname, len(state))} | |||
| </tr> | |||
| </table> | |||
|
|
|||
| <h3>Known nodes</h3> | |||
| <h3>${len(known_nodes)} ${"known node" if len(known_nodes) == 1 else "known nodes"}:</h3> | |||
There was a problem hiding this comment.
Would look the same in Jinja, really. It's not business logic, it's display logic.
There was a problem hiding this comment.
Fair point - in either case why not pre-compute this and pass it as rendering context?
There was a problem hiding this comment.
That's exactly why - it's not a context, it's display-specific. I could format it as
%if len(known_nodes)==1:
known node
%else:
known nodes
%endif
to avoid having Python logic in an evaluated expression, but it's only a formal change.
In general, if we start passing all the little things that only make sense inside the template from outside, we will end up with dozens of parameters in the call. For example, why not precalculate contrast_colors() outside, or checksum[0:8], or character_span()?
There was a problem hiding this comment.
To add to that: in my understanding, a template takes data that is convenient to work with in the code (in this case, a node object) and turns it into something that a human can read (or a JSON parser, or a compiler, in other cases). Sometimes it means repeating information, working with grammar, adding colors and so on. All that is not the caller's business.
If we start passing everything to the template, we don't really need a template engine at all - f-strings would suffice. Then, since you'll need to precompute a lot of values, you'll extract that code into a function, or maybe even its own module, and call it by passing only the node object to it. Which means you'll again end up with a Mako template. Except Mako adds one small thing - it inverts the Python syntax in this module so the strings do not need to be escaped anymore.
update_snapshot(), while the most recent one is actually contained in.known_nodes.Before:
After: