Extend policy probationary period until May 31st, 2021. #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekpierre
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
🎸 - Do we want to do a newsfagment (done for #2585 ) or since this is only temporary until we have a discussion, no need for a newsfragment...? It does affect app developers.
I guess after an in-depth discussion it is more likely to extend the probationary period than reduce 😅 , so a newsfragment this time would not be a bad thing.
|
Yes, let's do a newsfragment, it's exactly the kind of thing it's good at! Standby. |
KPrasch
added a commit
to KPrasch/nucypher
that referenced
this pull request
Apr 19, 2021
|
Done. |
|
One nitpick - May has 31 days 😅 , we should do the 31st. After that merge at will. |
derekpierre
reviewed
Apr 19, 2021
nucypher/config/constants.py
Outdated
| @@ -73,4 +73,4 @@ | |||
| NUCYPHER_EVENTS_THROTTLE_MAX_BLOCKS = 'NUCYPHER_EVENTS_THROTTLE_MAX_BLOCKS' | |||
|
|
|||
| # Probationary period (see #2353, #2584) | |||
| END_OF_POLICIES_PROBATIONARY_PERIOD = MayaDT.from_iso8601('2021-04-30T23:59:59.0Z') | |||
| END_OF_POLICIES_PROBATIONARY_PERIOD = MayaDT.from_iso8601('2021-05-30T23:59:59.0Z') | |||
There was a problem hiding this comment.
Suggested change
| END_OF_POLICIES_PROBATIONARY_PERIOD = MayaDT.from_iso8601('2021-05-30T23:59:59.0Z') | |
| END_OF_POLICIES_PROBATIONARY_PERIOD = MayaDT.from_iso8601('2021-05-31T23:59:59.0Z') |
newsfragments/2656.misc.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Extends policy probationary period until May 30th, 2021. No policies may be created on the network beyond this date. | |||
There was a problem hiding this comment.
Suggested change
| Extends policy probationary period until May 30th, 2021. No policies may be created on the network beyond this date. | |
| Extends policy probationary period until May 31st, 2021. No policies may be created on the network beyond this date. |
KPrasch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Other
Required reviews:
1
What this does:
Extends policy probationary period until May 31st, 2021.
Why it's needed:
Prevent CLI CI failures and give additional development runway before permitting long-lived and high-value policies.