squashed: Windows adaptation: Fixed some error points in Windows systems #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update packages/nuekit/src/site.js Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com> Update packages/nuekit/src/site.js Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com> Update init.js Add the 'force' option to the fs.rm command. Update packages/nuekit/src/site.js Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com> Update packages/nuekit/src/site.js Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com> Update init.js Update cli.js Update packages/nuekit/src/init.js Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
fritx
changed the title
|
Looks solid, thanks! Maybe later add some utility functions to avoid the repetition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've helped squash the commits in PR #135, from 10 into one, removing redundant ones:
The authors are supposed be kept untouched, which means if this PR is merged, #135 would be merged automatically (maybe?):
The CI is passing:https://github.com/fritx/nue/actions/runs/7446215080
( CI to test win32 is almost done !!
https://github.com/fritx/nue/commits/c1s-win-test
I will submit the PR after squashing ! )