Remove contradictory analogy #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I propose removing this initial comparison of `Dockerfile`s with Makefiles because: 1. It is inconsistent with the main analogy (see figure) where a `Dockerfile` is compared to source code 2. We later recommend including a Makefile in your repository to help remember arguments for commands As such, this comparison might cause unnecessary confusion.
|
Didn’t it already get resubmit? |
|
Ah, well if it's too late, then it's too late! 🤷♂️ If not, I think it would be a useful edit. I'll stop looking at it now anyway 😄 |
|
Well, if we get the text back once more, we can include it. None of the reviewers complained about this though, and unsolicited changes might have caused more trouble than benefit 🤷 . |
|
Unsolicited changes will indeed not work in our favour, so let's leave it in and see what the readers have to say. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose removing this initial comparison of
Dockerfiles with Makefiles because:Dockerfileis compared to source codeAs such, this comparison might cause unnecessary confusion. I also think the sentence reads better without this clause.