Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TeamServices/AzureDevOps interface #264

Closed
RLittlesII opened this issue Mar 28, 2019 · 12 comments · Fixed by matkoch/common#25
Closed

Improve TeamServices/AzureDevOps interface #264

RLittlesII opened this issue Mar 28, 2019 · 12 comments · Fixed by matkoch/common#25
Assignees
Milestone

Comments

@RLittlesII
Copy link
Contributor

I recently upgraded from 0.14.1 => 0.18.0 after upgrading my TFBuild commands broke.

Seems in the time since last upgrade color has been added to other loggers, and it broke the output to console (which is how you run TFBuild commands in Azure DevOps).

##[error]Unable to process command '�[96;1m##vso[artifact.upload containerfolder=Artifacts;artifactname=Artifacts;]C:\agent\_work\9\s\artifacts�[0m' successfully. Please reference documentation (http://go.microsoft.com/fwlink/?LinkId=817296)
@matkoch
Copy link
Member

matkoch commented Mar 31, 2019

As privately discussed, this is - judging from the framework - a user error. However, the TeamServices class should be extended and also renamed.

@matkoch matkoch changed the title TFBuild Commands only work with Log.Normal Improve TeamServices/AzureDevOps interface Apr 1, 2019
@matkoch
Copy link
Member

matkoch commented Apr 1, 2019

@RLittlesII assigned alright?

@RLittlesII
Copy link
Contributor Author

@matkoch Yes. I'll have a WIP PR this week.

@alphaleonis
Copy link
Contributor

The output definitely looks a bit funky. Attaching a picture displaying how it appears for us on an on premise TFS server.
image

@Skyqula
Copy link

Skyqula commented May 20, 2019

I can confirm @alphaleonis image. �[96;1m and [0m are added to nuke's writes. Note that there is a hidden character in there as well.

@MarchingCube
Copy link

Any chance of resolving this anytime? My team switched to use Azure DevOps and we have the same broken output in the console.

@matkoch
Copy link
Member

matkoch commented Aug 4, 2019

I'm not really sure how this should be "solved". Azure devops is not really consistent with how it handles the output. The following is from the same build. First image while it's running, second when it has finished.

image

image

@RLittlesII
Copy link
Contributor Author

I'll pull some raw logs and see if I can't glean something from them. Hopefully, we can find a pattern and solve the problem.

@matkoch
Copy link
Member

matkoch commented Aug 5, 2019

I'm not an AzureDevOps expert, but maybe someone could file an issue for them and reference it here. @MarchingCube @Skyqula @alphaleonis

@Skyqula
Copy link

Skyqula commented Aug 6, 2019

I looked trough the source again and inside the AnsiColorOutputSink I found the characters that are causing this issue. They are the ansi color coding.

So I turned to google and found this issue where a user asked how to color code output, to which the response is to use the logging commands.

I also found another issue stating that DevOps now seems to have partial ansi color support. The answer there seems to suggest that the latest version should have full support.

So to me it seems there are 2 ways to fix this issue.

  1. Wait it out and recommend users to update to the latest version of DevOps. This means no TFS support.
  2. Change the AzureDevOpsSink to use the official logging commands. Which should then support TFS as well. (looking at AzureDevOpsSink, warning and error already seem to bypass the ansi colors and AzureDevOps already seems to use some logging commands).

@matkoch
Copy link
Member

matkoch commented Aug 13, 2019

image

image

@matkoch matkoch closed this as completed Aug 13, 2019
@matkoch matkoch added this to the v0.22.0 milestone Aug 13, 2019
@lock
Copy link

lock bot commented Nov 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants