Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement accessibility labels for playback controls and result options #24

Closed
Piciok opened this issue Mar 1, 2017 · 1 comment
Closed

Implement accessibility labels for playback controls and result options #24

Piciok opened this issue Mar 1, 2017 · 1 comment
Assignees
@nukeop
Labels
enhancement This thread requests an enhancement to be implemented. good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time.
Projects
0.5.0
Milestone
0.5.0

Comments

@Piciok
Copy link

Piciok commented Mar 1, 2017

Currently the **buttons allowing to play/download a track found as well as the playback controls lack the accessibility labels allowing screenreaders to describe them to blind users. Tested under Windows and NVDA 2017.1
@nukeop nukeop self-assigned this Mar 1, 2017
@nukeop nukeop added the enhancement This thread requests an enhancement to be implemented. label Mar 31, 2017
@nukeop nukeop added help wanted good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time. labels Feb 12, 2018
@nukeop nukeop added this to To do in 0.5.0 via automation Aug 5, 2018
@nukeop nukeop added this to the 0.5.0 milestone Aug 5, 2018
@nukeop nukeop moved this from To do to In progress in 0.5.0 Sep 4, 2018
@nukeop nukeop closed this as completed in 9d6698c Sep 11, 2018
0.5.0 automation moved this from In progress to Completed Sep 11, 2018
@nukeop
Copy link
Owner

nukeop commented Sep 11, 2018

Hey, I added the labels you requested. Not sure if they're not too verbose, or too vague, so let me know if there's anything wrong. Also please let me know if there's anything more I can do to improve accessibility for you and other users.

nukeop added a commit that referenced this issue Sep 30, 2019
@nukeop
Add accessibility labels to some elements, fixes #24
4ce57b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nukeop nukeop

Labels
enhancement This thread requests an enhancement to be implemented. good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time.
Projects
No open projects
0.5.0
  
Completed
Milestone
0.5.0
Development

No branches or pull requests
2 participants
@Piciok @nukeop