[Feature request] Single track looping

[farahnur42]

As it stands right now the loop button isn't looping the track(s) and is stopping after a single play each. Not sure if this is a bug or intended behaviour of the looping functionality but it'd help a lot for someone like me who tends to keep songs on repeat for extended periods of time.

[mahimshridhar]

Can i take this ?

[nukeop]

Sure! I haven't started working on it yet. If you have any questions, feel free to ask me here.

[mahimshridhar]

Any suggestions on how do I solve this?

[nukeop]

What happens after a song is finished playing is controlled here:

nuclear/packages/app/app/containers/SoundContainer/index.js

Line 62 in b9feeb8

handleFinishedPlaying () {

There is already a check that handles looping the queue after we're done playing the last song. You could look at this code, introduce a new setting, and reset the current song based on that.

[mahimshridhar]

nuclear_install_1 is up-to-date
Starting nuclear_dev_1 ... error

ERROR: for nuclear_dev_1 Cannot start service dev: error gathering device information while adding custom device "/dev/snd": no such file or directory

ERROR: for dev Cannot start service dev: error gathering device information while adding custom device "/dev/snd": no such file or directory
ERROR: Encountered errors while bringing up the project.

I got this error while running docker-compose up dev and im not able to resolve this, can you please help me?

[nukeop]

What system is this? And what sound api?

[mahimshridhar]

im on macOS 10.14.5

[nukeop]

Ok, as a temporary workaround you can try using the old method of running the dev environment:

$ npx i -g lerna
$ lerna bootstrap
$ lerna run start

[mahimshridhar]

Im sorry, should i modify package.json for this to work? "lerna run start" wont work, it gives me:
lerna notice cli v3.16.4
lerna success run No packages found with the lifecycle script 'start'

[nukeop]

In this case, you can cd to packages/app and run npm start. I have no idea why lerna would fail to see the script in package.json.

[mahimshridhar]

ok this command is working but some reason it is stuck at loading,

[nukeop]

Look here: #480 (comment)

I will update the dependencies soon to resolve this.

[mahimshridhar]

Got it.

[mahimshridhar]

I got another dependency issue after taking a pull.

[mahimshridhar]

hey @nukeop any idea about this or did i mess up anything ?

[nukeop]

Hm, I doubt it's something that you did. I'll do some work later today to at least fix the build and then you could try again...

[mahimshridhar]

hey @nukeop sorry to bother you again but im still getting the above error.

[nukeop]

No problem. Maybe try cloning anew and reinstalling the dependencies? And btw, what version of node/npm are you using?

[mahimshridhar]

I tried reinstalling dependencies, didn't work. node version is 11.10.1 npm version is 6.9.0

[nukeop]

If you haven't yet, maybe try doing npm i --save-dev @babel/helper-remap-async-to-generator in packages/app?

[mahimshridhar]

weird part is im getting the same error even after installing @babel/helper-remap-async-to-generator

[nukeop]

In my case this package is correctly installed along with other dependencies. Does it exist at packages/app/node_modules/@babel?

[mahimshridhar]

yes it exists and i just deleted and cloned the repo again but that issue wont go

[EmberCS15]

1. I was looking at the UI. There is a repeat symbol for playlist/queue looping. Is there any such symbol for single track looping (Like a 1 on top of the repeat symbol)?

[nukeop]

Here's the list of all icons: https://react.semantic-ui.com/elements/icon/

There's no icon that suggests single track looping, but we could instead combine the normal repeat icon and the unicode symbol ❶.

[marko-ignjatovic]

Is someone working on this issue?

[nukeop]

Nope, I don't think so, would you like to try?

[marko-ignjatovic]

Yes, thank you

[marko-ignjatovic]

if (this.props.settings.loopAfterTrackEnd){
  this.props.actions.rerollTrack(musicSource, selectedStream, track);
}

Hmm, I am not sure why but this will work only for one time.

[Dola-Shuvi]

I would suggest using the UPDATE_PLAYBACK_PROGRESS action from player.js. You could dispatch an UPDATE_PLAYBACK_PROGRESS action with the progress and seek values set to zero like here:

nuclear/packages/app/app/actions/player.js

Line 41 in 4ba36b5

dispatch(updatePlaybackProgress(0, 0));

This restarts the track from the beginning and can be done multiple times.

[nukeop]

Reroll is for finding alternate streams if the one pulled by default is inaccurate (e.g. wrong video/version of the song, etc). Mongogamer's advice is accurate, just make sure that track end events are triggered (last.fm scrobbling etc)