White screen appears when artist is selected

[ItsMeAtd]

Sometimes the app freezes with a white screen when you click on an artist or try to play a song , I can play the artist songs when browsing through albums but not the artist page .

[nukeop]

Can you tell me which artist causes this?
I noticed there are some gaps in the data I'm getting from Discogs, might have to switch to a different provider.

[ItsMeAtd]

The bug appears mainly when I try to play K-pop artists ( GOT7 / Twice / Red Velvet / EXID) I did manage to play their songs if I searched for the albums though

[nukeop]

I'll look into it. Some links are incorrect and point to nonexistent pages.

[NightMachinery]

I get the white screen at startup! :(

[nukeop]

Which version and what system?

[NightMachinery]

This: https://github.com/nukeop/nuclear/releases/download/v0.4.2/nuclear-0.4.2.dmg

…

On Sun, May 20, 2018 at 7:21 PM, nukeop ***@***.***> wrote: Which version and what system? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#60 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Aii--mu-iLI2b6vuh5KdZaOQzW8YZW5pks5t0YLYgaJpZM4SghxG> .

[nukeop]

I'll try to build newer binaries today (0.4.3), and let you know when they're ready.

[NightMachinery]

Thanks👍🏻

…

On Sun, May 20, 2018 at 7:48 PM, nukeop ***@***.***> wrote: I'll try to build newer binaries today (0.4.3), and let you know when they're ready. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#60 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Aii--qsaL3d1NtJNe9RIhrwEI7m9AWW6ks5t0YkrgaJpZM4SghxG> .

[pqrth]

@nukeop I tried nuclear-0.4.2.dmg and nuclear-0.4.0.dmg on macOS 10.13.5, but the app window is completely white as @NightMachinary shared:

[nukeop]

Hm, the problem seems to be that youtube and other services change their APIs often, and when that happens, previous versions get broken. I'll try to figure out if that's what happened here and update relevant packages and release 0.4.3 soon...

Also there's a problem with broken data on Discogs (e.g. links to non-existing albums), which might force me eventually to use Musicbrainz.

On another note, clearly a log file is needed so we can figure out what's going on when you get a blank screen. And probably better response to errors.

[pqrth]

Thanks a ton for the fix @nukeop. I built the master branch at commit 2ccc96e for macOS 10.13.6, and I can confirm that this issue is fixed.

Now, my npm install had failed due to No package 'dbus-1' found. So instead of removing optional dependency as suggested in the README.md, I installed the package d-bus via Homebrew (brew install d-bus) and then the missing package was found.

@nukeop Do you think these instructions would be helpful in the README? If so, I can create a pull request to add them.

[nukeop]

dbus is a Linux subsystem and as such is specified as an optional dependency. While it probably can be installed on Macs, I doubt that it'll do anything useful. On Linux, it's used for communicating with system widgets that can control the player.

Since you're saying that installation fails, this must mean that specifying it as an optional dependency is not enough (there should be a warning, but it should succeed nonetheless). In fact, there are two sets of different electron server files specifically for this reason (considering that dbus will not be present by default on MacOS and Windows).

If you want, you can add the instructions as a temporary workaround until we can figure out how to skip it completely.