New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted HelpButton component into TypeScript #1590

Merged

nukeop merged 2 commits into nukeop:master from sicin:rework-help-button-into-ts

Apr 30, 2024

Contributor

sicin commented Apr 13, 2024

Small rework. As seen in other button examples, a prop allowing for future extension of the button was added, the rest stayed as is.


          change help button into typescript

05ab0dd

nukeop reviewed

View reviewed changes

packages/app/app/components/HelpButton/index.tsx Outdated Show resolved Hide resolved


          prevent unexpected props and children from being passed

8f0b23b

nukeop merged commit 68ad52f into nukeop:master

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment