Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context support for Group API #109

Merged
merged 4 commits into from
May 14, 2019
Merged

Context support for Group API #109

merged 4 commits into from
May 14, 2019

Conversation

nukosuke
Copy link
Owner

@nukosuke nukosuke commented May 13, 2019 •
edited
Loading

#70

@nukosuke nukosuke self-assigned this May 13, 2019
@nukosuke nukosuke added this to the v0.3.0 milestone May 13, 2019
@nukosuke nukosuke marked this pull request as ready for review May 13, 2019 08:15
@nukosuke nukosuke requested a review from tamccall May 13, 2019 08:16
tamccall
tamccall approved these changes May 14, 2019
View reviewed changes
Copy link
Contributor

@tamccall tamccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nukosuke nukosuke merged commit 13a9cff into master May 14, 2019
@nukosuke nukosuke deleted the context-group branch May 14, 2019 17:01
fairyhunter13 added a commit to fairyhunter13/go-zendesk that referenced this pull request Jul 12, 2020
@fairyhunter13
Context support for Group API (nukosuke#109)
996bceb 
* Fix test for context support of group API

* Use context for HTTP methods

* Regenerate mock client

* Fix README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamccall tamccall tamccall approved these changes

Assignees

@nukosuke nukosuke

Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nukosuke @tamccall