Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context support for trigger #117

Merged
merged 3 commits into from
May 15, 2019
Merged

Context support for trigger #117

merged 3 commits into from
May 15, 2019

Conversation

nukosuke
Copy link
Owner

Resolve #70

@nukosuke nukosuke added this to the v0.3.0 milestone May 15, 2019
@nukosuke nukosuke self-assigned this May 15, 2019
@nukosuke nukosuke requested a review from tamccall May 15, 2019 01:48
@nukosuke nukosuke mentioned this pull request May 15, 2019
Merged
tamccall
tamccall approved these changes May 15, 2019
View reviewed changes
Copy link
Contributor

@tamccall tamccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nukosuke nukosuke merged commit f43cd8a into master May 15, 2019
@nukosuke nukosuke deleted the context-trigger branch May 15, 2019 14:01
fairyhunter13 added a commit to fairyhunter13/go-zendesk that referenced this pull request Jul 12, 2020
@fairyhunter13
Context support for trigger (nukosuke#117)
7475f63 
* Fix test for context support of trigger

* Add context support for trigger

* Regenerate mock client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamccall tamccall tamccall approved these changes

Assignees

@nukosuke nukosuke

Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Add go context to all client methods.
2 participants
@nukosuke @tamccall