Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unmarshal support for Ticket GroupID #287

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Unmarshal support for Ticket GroupID #287

merged 1 commit into from
Oct 13, 2023

Conversation

raintomista
Copy link
Contributor

There are times that group_id is being returned as string instead of number when using Show Changes to Ticket endpoint and causes json unmarshal to fail

json: cannot unmarshal string into Go struct field Ticket.result.ticket.group_id of type int64

Changing the type of Ticket.GroupID with json.Number seems to solve the issue.

@raintomista raintomista marked this pull request as draft September 28, 2023 12:37
@raintomista raintomista marked this pull request as ready for review October 2, 2023 14:53
@nukosuke nukosuke merged commit 13fdfd8 into nukosuke:master Oct 13, 2023
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nukosuke nukosuke nukosuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raintomista @nukosuke